-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configuration error in Visual Studio #24
Open
PhilJollans
wants to merge
15
commits into
royben:master
Choose a base branch
from
PhilJollans:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Debug to the <Configurations> tag. This fixes an error message "Current solution contains incorrect configurations mappings" on opening Visual Studio.
This reverts commit 0823876.
Add Debug to the <Configurations> tag. This fixes an error message "Current solution contains incorrect configurations mappings" on opening Visual Studio.
I do not have version 10.0.17134.0 installed on my machine, so I have switched to 10.0.17763.0, which I do have installed. This change is purely for my own convenience.
In my opinion, the control WpfGraphControl belongs in the core DLL RealTimeGraphX.WPF and not in the demo project.
Define two new properties on the WpfGraphControl: - AxisCaptionX - AxisCaptionY In the control template for WpfGraphControl, define a grid column for the Y caption and a row for the X caption and show the captions using TextBlock controls. The new column and row auto size, and collapse to zero width or height respectively if the caption is empty.
In WpfGraphControl - Define a new property GridLinesBrush In Generic.xaml - Use the property GridLinesBrush to set the Foreground property on the WpfGraphGridLines control - Set the BorderThickness of WpfGraphSurface to 1 on all four sides, so that box has the same colour on all four sides, in particular if the GridLinesBrush property is set to a different colour.
Add the properties: - CornerRadius - ShowAxisX - ShowAxisY - WidthAxisY Swap the usage of StringFormatX and StringFormatY, which in my opinion where used incorrectly.
The property XStartBehavior specifies the behavior before there is enough data to fill up the X axis. There are three options: - Stretch the data, which is the original behavior - Fill the diagram from the left and start scrolling left when the diagram is full - Show new data on the right hand margin and scroll left from the beginning
…trol.DivisionsX and .DivisionsY Replace the Ticks property on WpfGraphAxisControl with a Divisions property and define Ticks as Divisions+1. With this change, the Divisions property can have the same numeric value as the Rows and Columns properties on the WpfGraphGridLines control. Add the properties DivisionsX and DivisionsY to WpfGraphControl. Add TemplateBindings to the control template in Generic.xaml, to bind the DivisionsX and DivisionsY properties to the Rows and Columns of the WpfGraphGridLines control and to the Divisions properties of the respective WpfGraphAxisControl controls.
Update versions to 1.0.0.2
Add a new abstract method ExpandRange to GraphDataPoint to expand the min and max values by a factor applied to the difference between the two values, i.e. min = min - factor * ( max - min ) max = max + factor * ( max - min ) This will be used with the AutoY scaling option. Obviously, it would be nice to make the factor configurable, but in this version it is hard coded as 0.05. Note that the method ExpandRange works like a static method, in that it does not use the "this" reference at all. It is not static, because it is abstract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On opening the RealTimeGraphX solution in Visual Studio I get the error message "Current solution contains incorrect configurations mappings. It may cause projects to not work correctly. Open the Configuration Manager to fix them. "
This - I believe - is because the project file RealTimeGraphX refers to a Debug configuration, but the tag only specifies the Release configuration.
Simply adding Debug to the tag fixes this problem.
Note:
I'm a newbie when it comes to Pull requests.
I checked in two other changes which I did not want to be part of the pull request, and then reverted them. That is why there are three commits in this pull request. The only relevant change is in RealTimeGraphX.csproj.