-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and assert basic CS using CI #9246
Conversation
d7e4e47
to
d47a3a8
Compare
This is cool. I'd keep old switch/case indentation if possible. Not that I have strong opinion about the syntax, but I'd like to keep the diff less invasive. Please. |
The In a long them, this should pay off, as the PSR-12 CS [2] recommends/allows only this format. If you do a lot of merged into bugfix branches, I advise to add and run the PHP CS Fixer on these branches too, so the whitespace CS is the same and the diffs minimal. [1] https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/doc/rules/whitespace/statement_indentation.rst |
5c4dea5
to
ee2ac4e
Compare
cec26e4
to
fffe315
Compare
fffe315
to
563d341
Compare
@alecpl can this PR be merged? |
Probably not before this weekend. |
Assert basic coding style according to the latest standards and reduce merge conflicts in a long term.
This PR lands changes for non-functional (and mostly whitespace) changes only. I plan to fix more CS in upcoming PRs.