Address feedback

Signed-off-by: Roshan Khatri <[email protected]>
roshkhatri · May 22, 2024 · e2deb63 · e2deb63
1 parent 7621474
commit e2deb63
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/cluster_legacy.c b/src/cluster_legacy.c
@@ -2367,7 +2367,7 @@ void clusterUpdateSlotsConfigWith(clusterNode *sender, uint64_t senderConfigEpoc
         serverLog(LL_NOTICE,"Discarding UPDATE message about myself.");
         return;
     }
-    
+
     for (j = 0; j < CLUSTER_SLOTS; j++) {
         if (bitmapTestBit(slots,j)) {
             sender_slots++;

diff --git a/tests/unit/cluster/announced-endpoints.tcl b/tests/unit/cluster/announced-endpoints.tcl
@@ -8,6 +8,9 @@ start_cluster 2 2 {tags {external:skip cluster}} {
         }
         set count [expr [llength $::servers] + 1]
         set used_port [find_available_port $baseport $count]
+
+        # We execute CLUSTER SLOTS command to trigger the debug assertions, ensuring that the cached response is 
+        # invalidated when we update any of cluster-announce-tls-port or cluster-announce-port.
         R 0 CLUSTER SLOTS
         R 1 CLUSTER SLOTS