fix the usee of stack allocated version of dictIterator.

Signed-off-by: Roshan Khatri <[email protected]>
roshkhatri · May 10, 2024 · a0415c8 · a0415c8
1 parent 8a308c0
commit a0415c8
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/cluster_legacy.c b/src/cluster_legacy.c
@@ -6940,12 +6940,12 @@ void clusterPromoteSelfToMaster(void) {
 }
 
 void updateAllCachedNodesHealth(void) {
-    dictIterator *di =  zmalloc(sizeof(*di));
+    dictIterator di;
+    dictInitSafeIterator(&di, server.cluster->nodes);
     dictEntry *de;
     clusterNode *node;
     int overall_health_changed = 0;
-    dictInitSafeIterator(di, server.cluster->nodes);
-    while((de = dictNext(di)) != NULL) {
+    while((de = dictNext(&di)) != NULL) {
         node = dictGetVal(de);
         int present_is_node_healthy = isNodeAvailable(node);
         if (present_is_node_healthy != node->is_node_healthy) {