Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jazzy] Bugfix: Update metadata with new file_info before saving it the first time in the file (backport #1843) #1853

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 4, 2024

This PR is a bug fix for missing file_info for newly created file in saved metadata.

When we are switching to new storage, the correct behavior shall be as follows:

  1. Save metadata to storage
  2. Close current storage
  3. Open new storage for read_write
  4. Update metadata with a newly created file
  5. Save metadata to storage
    This is an automatic backport of pull request Bugfix: Update metadata with new file_info before saving it the first time in the file #1843 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner November 4, 2024 17:12
@mergify mergify bot requested review from gbiggs and james-rms and removed request for a team November 4, 2024 17:12
@MichaelOrlov MichaelOrlov changed the title Bugfix: Update metadata with new file_info before saving it the first time in the file (backport #1843) [jazzy] Bugfix: Update metadata with new file_info before saving it the first time in the file (backport #1843) Nov 4, 2024
@MichaelOrlov
Copy link
Contributor

Pulls: #1853
Gist: https://gist.githubusercontent.com/MichaelOrlov/628bd3ec71b6285489fe85cb11f17aaf/raw/5796bc669ffb763364608256f084c9fd8f2fd8ad/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_compression rosbag2_cpp rosbag2_tests
TEST args: --packages-above rosbag2_compression rosbag2_cpp rosbag2_tests
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14798

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit 29c3e45 into jazzy Nov 7, 2024
12 checks passed
@MichaelOrlov MichaelOrlov deleted the mergify/bp/jazzy/pr-1843 branch November 7, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant