Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mcap to v1.4.0 #1774

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Bump mcap to v1.4.0 #1774

merged 2 commits into from
Aug 9, 2024

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Aug 6, 2024 •
edited by MichaelOrlov
Loading

  • This PR updates mcap_vendor package to use latest mcap 1.4.0 version

@mosfet80
Update mcap
6f52120 
Update mcap cpp to last version

Signed-off-by: mosfet80 <[email protected]>
@mosfet80 mosfet80 requested a review from a team as a code owner August 6, 2024 09:21
@mosfet80 mosfet80 requested review from gbiggs and jhdcs and removed request for a team August 6, 2024 09:21
fujitatomoya
fujitatomoya approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor version update and it does not change the dependencies. looks good to me.

MichaelOrlov
MichaelOrlov approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MichaelOrlov
Copy link
Contributor

Pulls: #1774
Gist: https://gist.githubusercontent.com/MichaelOrlov/5236f1c28a2736b7829744ead1a5929d/raw/67d508ed96a8847c52a94d100028cd3821bd88ee/ros2.repos
BUILD args: --packages-above-and-dependencies mcap_vendor rosbag2_storage_mcap rosbag2_transport rosbag2_cpp
TEST args: --packages-above mcap_vendor rosbag2_storage_mcap rosbag2_transport rosbag2_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14392

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Contributor

Re-run Linux and RHEL CI jobs after attempting to fix CI infrastructure failures.

  • Linux Build Status
  • Linux-rhel Build Status

@MichaelOrlov MichaelOrlov changed the title Update mcap Bump mcap to v1.4.0 Aug 9, 2024
@MichaelOrlov
Copy link
Contributor

CI is green, merging then.

@MichaelOrlov MichaelOrlov merged commit e6797ae into ros2:rolling Aug 9, 2024
12 checks passed
@MichaelOrlov MichaelOrlov mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@james-rms james-rms james-rms approved these changes

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs was automatically assigned from ros2/tooling-reviewers

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs was automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mosfet80 @MichaelOrlov @james-rms @fujitatomoya