Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lz4 to v1.10 #1773

Closed
wants to merge 1 commit into from
Closed

Update lz4 to v1.10 #1773

wants to merge 1 commit into from

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Aug 6, 2024

implements multithread support . ->increase speed
a lot of fix https://github.com/lz4/lz4/releases/tag/v1.10.0

@mosfet80
Update lz4 to v1.10
8965daf 
implements multithread support . ->increase speed
a lot of fix https://github.com/lz4/lz4/releases/tag/v1.10.0

Signed-off-by: mosfet80 <[email protected]>
@mosfet80 mosfet80 requested a review from a team as a code owner August 6, 2024 09:00
@mosfet80 mosfet80 requested review from emersonknapp and james-rms and removed request for a team August 6, 2024 09:00
clalancette
clalancette requested changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with other places, I'd prefer if this stayed the same as the version released in Ubuntu 24.04 (which is 1.9.4). So I don't think we should take this update.

@MichaelOrlov
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette requested changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp was automatically assigned from ros2/tooling-reviewers

@james-rms james-rms Awaiting requested review from james-rms james-rms was automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mosfet80 @MichaelOrlov @clalancette