Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upload-artifact into test.yml #1771

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Update upload-artifact into test.yml #1771

merged 1 commit into from
Aug 9, 2024

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Aug 6, 2024

switch to node 20
node<20 is deprecaded

@mosfet80 mosfet80 requested a review from a team as a code owner August 6, 2024 08:32
@mosfet80 mosfet80 requested review from gbiggs and jhdcs and removed request for a team August 6, 2024 08:32
christophebedard
christophebedard approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change can't currently be tested because of an unrelated test failure, but it looks good to me.

@mosfet80 @MichaelOrlov
Update upload-artifact into test.yml
ec70c76 
switch to node 20
node<20 is deprecaded

Signed-off-by: mosfet80 <[email protected]>
@MichaelOrlov
Copy link
Contributor

Rebased to get the latest fix for CI failure and be able to test this PR.

@MichaelOrlov
Copy link
Contributor

CI is green - merging then.

@MichaelOrlov
Copy link
Contributor

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link

mergify bot commented Aug 9, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

@MichaelOrlov MichaelOrlov reopened this Aug 9, 2024
@MichaelOrlov MichaelOrlov merged commit ce918b7 into ros2:rolling Aug 9, 2024
20 of 21 checks passed
mergify bot pushed a commit that referenced this pull request Aug 9, 2024
@mosfet80 @mergify
Update upload-artifact into test.yml (#1771)
11df75e 
switch to node 20
node<20 is deprecaded

Signed-off-by: mosfet80 <[email protected]>
(cherry picked from commit ce918b7)
@mergify mergify bot mentioned this pull request Aug 9, 2024
Merged
MichaelOrlov pushed a commit that referenced this pull request Aug 9, 2024
@mosfet80 @MichaelOrlov
Update upload-artifact into test.yml (#1771)
b123660 
switch to node 20
node<20 is deprecaded

Signed-off-by: mosfet80 <[email protected]>
(cherry picked from commit ce918b7)
MichaelOrlov pushed a commit that referenced this pull request Aug 9, 2024
@mergify @mosfet80
Update upload-artifact into test.yml (#1771) (#1781)
785f2cf 
switch to node 20
node<20 is deprecaded

Signed-off-by: mosfet80 <[email protected]>
(cherry picked from commit ce918b7)

Co-authored-by: mosfet80 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@christophebedard christophebedard christophebedard approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs was automatically assigned from ros2/tooling-reviewers

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs was automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mosfet80 @MichaelOrlov @christophebedard