fix: resolve the memory leak in the subcription message #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
Jan 15, 2025
|
https://github.com/Mergifyio backport jazzy humble |
|
Testing against the ros.repos, no regression was found. |
✅ Backports have been created
|
ahcorde
pushed a commit
that referenced
this pull request
Jan 15, 2025
…421) (cherry picked from commit 2930620) Co-authored-by: Yuyuan Yuan <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Jan 15, 2025
…420) (cherry picked from commit 2930620) Co-authored-by: Yuyuan Yuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A memory leak was caught due to the memory leak in the subscription message. This PR addresses this by using the default destructor to drop the member
Payloadautomatically.