Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gid_hash_ from AttachmentData (backport #416) #418

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 13, 2025

This member is computed in the constructor which is in turn called in rmw_publish. This hash is not serialized as part of the attachment.

I noticed this when profiling the multi-process iRobot benchmark, where hash_gid was taking around 23% of the running time of rmw_publish.


This is an automatic backport of pull request #416 done by Mergify.

This member is computed in the constructor which is in turn called
in `rmw_publish`. This hash is not serialized as part of the attachment.

(cherry picked from commit f040f5c)

# Conflicts:
#	rmw_zenoh_cpp/src/detail/attachment_helpers.cpp
#	rmw_zenoh_cpp/src/detail/attachment_helpers.hpp
@mergify mergify bot added the conflicts label Jan 13, 2025
Copy link
Author

mergify bot commented Jan 13, 2025

Cherry-pick of f040f5c has failed:

On branch mergify/bp/humble/pr-416
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit f040f5c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rmw_zenoh_cpp/src/detail/attachment_helpers.cpp
	both modified:   rmw_zenoh_cpp/src/detail/attachment_helpers.hpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde merged commit 8aea996 into humble Jan 14, 2025
4 checks passed
@ahcorde ahcorde deleted the mergify/bp/humble/pr-416 branch January 14, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants