Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward Compatibility with ROS 2 Humble #335

Closed
wants to merge 7 commits into from

Conversation

YuanYuYuan
Copy link
Contributor

@YuanYuYuan YuanYuYuan commented Dec 10, 2024

Description

This is a draft that backward supports Humble #303. It's currently based on #333.

Status

  • Basic pub/sub works.
  • The workflow should be changed to Humble.
  • rclcpp test failures
30 - test_intra_process_manager (Failed)
53 - test_parameter (Failed)
56 - test_publisher (Failed)
61 - test_qos (Failed)
64 - test_qos_event (Failed)
91 - test_guard_condition (Failed)
92 - test_wait_set (Failed)

@YuanYuYuan YuanYuYuan marked this pull request as draft December 10, 2024 17:04
@clalancette
Copy link
Collaborator

So the way that we usually do this is to create a branch for each of the distributions. In this case, what we'll want to do is to create a humble branch, and then retarget this at that branch. However, I want to get some more of the major work landed on rolling before we make that branch. So I think this is appropriate as a draft for now.

@Yadunund
Copy link
Member

We've created a humble branch in this repo which this PR can target instead of rolling. We will selectively backport changes to the humble branch as we merge changes in rolling.

@clalancette clalancette changed the base branch from rolling to humble December 23, 2024 16:07
@Yadunund
Copy link
Member

Yadunund commented Jan 2, 2025

@YuanYuYuan do you mind rebasing to the latest humble? We can merge after

@clalancette
Copy link
Collaborator

I'm actually going to close this in favor of #388, which makes this work on Humble.

@clalancette clalancette closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants