Include topic type and hash in key expression #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/fix_type_mismatch
branch
2 times, most recently
from
ffedca3 to
fdde316
Compare
Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/fix_type_mismatch
branch
from
fdde316 to
839b425
Compare
Yadunund
changed the title
clalancette
requested changes
Jun 21, 2024
Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Yadu <[email protected]>
Signed-off-by: Yadunund <[email protected]>
clalancette
requested changes
Jun 24, 2024
Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Yadu <[email protected]>
Signed-off-by: Yadunund <[email protected]>
clalancette
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #117 while factoring in #201 (comment).
The keyexprs now adopt the format
Topic names are no longer mangled.
I will follow up with a separate PR to also add the
topic_hashto the liveliness tokens so that we can include the hash in the endpoint info when querying topic info.