Solve of issue #111

[shivangvijay]

Based on my understanding, I attempt to address issue #111. If it doesn't align with your expectations, please provide further clarification on this matter.

[Yadunund]

@shivangvijay appreciate the effort to address the outstanding issue but the implementation here is not quite what is expected. I highly recommend commenting on the ticket to discuss implementation strategies before working on a PR in case something is unclear. It's also a good way to let others know you're working on this ticket to prevent duplicated efforts. Please look at my comments below.

[shivangvijay]

Thank you, @Yadunund , for your guidance. In the future, I will comment on the ticket.

I am unable to understand why my build pipeline is failing, I am not changing anything in the CMakelists.txt file. Please let me know what I am doing wrong.

[Yadunund]

Thanks for addressing the feedback. One more minor change.

[shivangvijay]

@Yadunund Is there any work remaining in this PR? Is not get merged till now.

[Yadunund]

@shivangvijay sorry for the delay.

I think we should add a / separator between the domain id and mangled topic name such that the keyepxression would look like 0/%chatter. This way, if we ever need to get the original constituents of a keyexpression, we can split over /. We adopt this approach for the lifecycle token's keyexpression.

So could you append a / to the domain id string?

[shivangvijay]

@shivangvijay sorry for the delay.

I think we should add a / separator between the domain id and mangled topic name such that the keyepxression would look like 0/%chatter. This way, if we ever need to get the original constituents of a keyexpression, we can split over /. We adopt this approach for the lifecycle token's keyexpression.

So could you append a / to the domain id string?

If I add '/' in the domain ID string, I am facing an issue. I have attached a screenshot for your reference.

I tried below thing:-

But the return of z_keyexpr is not a "z_owned_keyexpr_t" type.

[shivangvijay]

Now, I am exploring https://github.com/eclipse-zenoh/zenoh-cpp to understand z_owned_keyexpr_t and implementation of z_keyexpr, and how to convert it's return value to z_owned_keyexpr_t.

[Yadunund]

Why not simply avoid calling z_keyexpr_join?

const std::string keyexpr_str = std::to_string(domain_id) + "/" + liveliness::mangle_name(topic_name);
return z_keyexpr(keyexpr_str.c_str());

[shivangvijay]

Why not simply avoid calling z_keyexpr_join?

const std::string keyexpr_str = std::to_string(domain_id) + "/" + liveliness::mangle_name(topic_name);
return z_keyexpr(keyexpr_str.c_str());

z_keyexpr return z_keyexpr_t type not z_owned_keyexpr_t type.

[Yadunund]

Sorry I meant z_keyexpr_new.