Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update workflow base OS and container to ubuntu:noble. #409

Merged
merged 2 commits into from
Oct 30, 2024
Merged

update workflow base OS and container to ubuntu:noble. #409

merged 2 commits into from
Oct 30, 2024

Conversation

fujitatomoya
Copy link
Contributor

follow up #407, see #407 (comment)

@fujitatomoya
Copy link
Contributor Author

@JanStaschulat @pablogs9 @christophebedard either of you can take a look?

@fujitatomoya
Copy link
Contributor Author

@JanStaschulat @pablogs9 can you merge this?

christophebedard
christophebedard approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fujitatomoya
Copy link
Contributor Author

@JanStaschulat can you merge this? i do not think this does any harm.

@JanStaschulat JanStaschulat merged commit 6f0a9ed into ros2:rolling Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanStaschulat JanStaschulat JanStaschulat approved these changes

@pablogs9 pablogs9 pablogs9 approved these changes

@christophebedard christophebedard christophebedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fujitatomoya @christophebedard @pablogs9 @JanStaschulat