Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move example messages out of std_msgs #89

Closed
tfoote opened this issue Apr 2, 2020 · 2 comments
Closed

Move example messages out of std_msgs #89

tfoote opened this issue Apr 2, 2020 · 2 comments
Assignees

Comments

@tfoote
Copy link
Contributor

tfoote commented Apr 2, 2020

This is a follow up to the Aggregate Foxy Message API Review

Followup to: https://github.com/ros2/common_interfaces/pull/86/files#r392505128

We should look at moving any of the messages that are not actually standard to something more like example_msgs this will set expectations more clearly.

This could have wide ranging effects and it might be worth adding explicit warnings into the generators to help with the migration process.

@tfoote tfoote self-assigned this Apr 2, 2020
tfoote added a commit that referenced this issue May 18, 2020
tfoote added a commit that referenced this issue May 18, 2020
)

* Add deprecation messages to all messages now in example_interfaces
Followup to #89

Signed-off-by: Tully Foote <[email protected]>
@tfoote
Copy link
Contributor Author

tfoote commented May 19, 2020

Done in a combination of #116 and ros2/example_interfaces#11

@ros-discourse
Copy link

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/soss-a-whole-new-approach-to-your-ros-1-ros-2-bridge/17040/18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants