Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddynamic reconfigure based joint state publisher #70

Open
wants to merge 3 commits into
base: noetic-devel
Choose a base branch
from

Conversation

lucasw
Copy link

@lucasw lucasw commented Sep 25, 2021

To use this all the normal joint_state_publisher settings, but run joint_state_publisher_dr instead, then use a dynamic reconfigure client (like the standard rqt one) to move joints around.

Addresses #12

Do I need to do something to respect the threading of the main jsp loop, my joint updates from dynamic reconfigure callbacks could be in the middle of something in the regular jsp?

Updated noetic version of https://github.com/lucasw/joint_state_publisher/tree/dynamic_reconfigure

@lucasw lucasw force-pushed the noetic-dynamic-reconfigure branch from d2364ed to 415b9ba Compare September 25, 2021 16:08
@clalancette
Copy link
Collaborator

I have to say that I'm somewhat reluctant to take this as a new script in this package. In particular, it looks like there is nothing that prevents this from being a separate package that just depends on joint_state_publisher_gui. @lucasw what do you think about making it a separate package and releasing that package into Noetic?

@lucasw lucasw force-pushed the noetic-dynamic-reconfigure branch from 5a8e501 to d54c3dc Compare November 9, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants