Add suported modes to canopen_fake_slaves README
#337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that actually three more modes are supported currently by the code. I believe that `Profiled Velocity` here is not well implemented (i.e. no accelleration ramps are implemented, velocity is directly and abruptly changed) but, at least for some mocking purposes, the mode is already supported in the sense that user won't get an error by requesting mode switching to `profiled velocity`.
hellantos
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that actually three more modes are supported currently by the code.
I believe that
Profiled Velocityhere is not well implemented (i.e. no accelleration ramps are implemented, velocity is directly and abruptly changed) but, at least for some mocking purposes, the mode is already supported in the sense that user won't get an error by requesting mode switching toprofiled velocity.