Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing shutdown call in test class (backport #695) #698

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 22, 2025

According to the API description of WaitForTopics https://docs.ros.org/en/rolling/p/launch_testing_ros/launch_testing_ros.wait_for_topics.html

In the other occurrences we had that already.


This is an automatic backport of pull request #695 done by Mergify.

(cherry picked from commit d6383fc)

# Conflicts:
#	example_11/test/test_carlikebot_launch.py
@mergify mergify bot added the conflicts label Jan 22, 2025
Copy link
Contributor Author

mergify bot commented Jan 22, 2025

Cherry-pick of d6383fc has failed:

On branch mergify/bp/humble/pr-695
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit d6383fc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   example_11/test/test_carlikebot_launch.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-695 branch January 22, 2025 21:11
@christophfroehlich
Copy link
Contributor

see #699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant