-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix view_controller_chains #2026
Draft
christophfroehlich
wants to merge
7
commits into
master
Choose a base branch
from
fix/view_controller_chains
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fe1d47c.
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2026 +/- ##
==========================================
- Coverage 89.34% 89.33% -0.01%
==========================================
Files 132 132
Lines 14688 14686 -2
Branches 1269 1269
==========================================
- Hits 13123 13120 -3
- Misses 1090 1092 +2
+ Partials 475 474 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Thank you so much to fix this. The new graph generated makes way more sense than the previous one 😀 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #812 and fixes #1095:
python3-graphviz
IS available as rosdep, and produces the desired output. I don't see the necessity to use pygraphviz, unless someone can fix the code for real.Before (example_16)
After
I also added a
--save
option to save the output as PDF in the current directory instead of viewing it.There is still something wrong in the representation, I'll keep it as draft.