Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view_controller_chains #2026

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Jan 31, 2025

This reverts #812 and fixes #1095: python3-graphviz IS available as rosdep, and produces the desired output. I don't see the necessity to use pygraphviz, unless someone can fix the code for real.

Before (example_16)
controller_diagram gv
After
controller_diagram

I also added a --save option to save the output as PDF in the current directory instead of viewing it.

There is still something wrong in the representation, I'll keep it as draft.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.33%. Comparing base (3755e03) to head (b91b5ee).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2026      +/-   ##
==========================================
- Coverage   89.34%   89.33%   -0.01%     
==========================================
  Files         132      132              
  Lines       14688    14686       -2     
  Branches     1269     1269              
==========================================
- Hits        13123    13120       -3     
- Misses       1090     1092       +2     
+ Partials      475      474       -1     
Flag Coverage Δ
unittests 89.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@Juliaj
Copy link

Juliaj commented Feb 1, 2025

Thank you so much to fix this. The new graph generated makes way more sense than the previous one 😀 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

view_controller_chains does not work with example
2 participants