Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async controllers deactivation regime #2017

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

Right now, we have the wait_for_trigger_update_to_finish method that waits for the current cycle to finish, but the problem would be the case when it is finished and a new cycle is triggered that means, even the previous cycle is finished, a new cycle might be triggered and this might cause segmentation fault, as the release interfaces is already called by deactivation method. This PR ensure to fix the issue

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.37%. Comparing base (fbfc01d) to head (772c788).

Files with missing lines Patch % Lines
...roller_interface/src/controller_interface_base.cpp 57.14% 7 Missing and 2 partials ⚠️
...ontroller_manager/test/test_controller_manager.cpp 95.12% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2017   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files         132      132           
  Lines       14649    14748   +99     
  Branches     1261     1267    +6     
=======================================
+ Hits        13092    13181   +89     
- Misses       1091     1099    +8     
- Partials      466      468    +2     
Flag Coverage Δ
unittests 89.37% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...controller_interface/controller_interface_base.hpp 91.66% <ø> (ø)
controller_manager/src/controller_manager.cpp 76.28% <100.00%> (ø)
...ontroller_manager/test/test_controller_manager.cpp 96.00% <95.12%> (-0.10%) ⬇️
...roller_interface/src/controller_interface_base.cpp 82.92% <57.14%> (-4.70%) ⬇️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant