-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow id_ed25519 keypair name #54
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - some bits that we might add:
- an item to the NEWS.md file
- check through the vignette and add an explanatory message so that people are not alarmed if their keypair differs
- probably worth in a future issue offering to create these new keys rather than rsa as they are meant to be more secure - probably worth doing that before CRAN release though
R/util.R
Outdated
@@ -146,3 +146,33 @@ cyphr_file <- function(...) { | |||
file_copy <- function(...) { | |||
stopifnot(file.copy(...)) | |||
} | |||
|
|||
guess_key_options <- function(error = FALSE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love this bit - particularly that the error is a different sort of thing. Perhaps:
guess_key_error <- function() {
paste(sprintf("%s[.pub] pair", guess_key()), collapse = " or ")
}
replacing use of guess_key_options(error = TRUE)
Later we might want to generalise this approach and allow setting key priorities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree - have separated that out so we have one function providing the list of key-stubs and separate error func...
|
Going back to draft, as it seems from the issue that just detecting the filename is not sufficient |
Addresses issue #53