Skip to content

Commit

Permalink
update tests to close #157
Browse files Browse the repository at this point in the history
  • Loading branch information
mpadge committed Aug 19, 2022
1 parent 4e4da87 commit 5e2002f
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: pkgcheck
Title: rOpenSci Package Checks
Version: 0.1.0.006
Version: 0.1.0.007
Authors@R: c(
person("Mark", "Padgham", , "[email protected]", role = c("aut", "cre"),
comment = c(ORCID = "0000-0003-2172-5265")),
Expand Down
2 changes: 1 addition & 1 deletion codemeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"codeRepository": "https://github.com/ropensci-review-tools/pkgcheck",
"issueTracker": "https://github.com/ropensci-review-tools/pkgcheck/issues",
"license": "https://spdx.org/licenses/GPL-3.0",
"version": "0.1.0.006",
"version": "0.1.0.007",
"programmingLanguage": {
"@type": "ComputerLanguage",
"name": "R",
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/_snaps/extra-checks/checks-extra.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ <h2>Checks for <a href="https://github.com/ropensci-review-tools/pkgstats">pkgst
<li>❌ Package depends on the following obsolete packages: [blah]</li>
<li>❌ does not have a ‘codemeta.json’ file.</li>
<li>❌ does not have a ‘contributing’ file.</li>
<li>❌ The following functions have no documented return values: [ctags_install, desc_stats, rd_stats, tags_data]</li>
<li>✅ uses ‘roxygen2’.</li>
<li>✅ ‘DESCRIPTION’ has a URL field.</li>
<li>✅ ‘DESCRIPTION’ has a BugReports field.</li>
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/_snaps/extra-checks/checks-extra.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ git hash: [](https://github.com/ropensci-review-tools/pkgstats/tree/)
- :heavy_multiplication_x: Package depends on the following obsolete packages: [blah]
- :heavy_multiplication_x: does not have a 'codemeta.json' file.
- :heavy_multiplication_x: does not have a 'contributing' file.
- :heavy_multiplication_x: The following functions have no documented return values: [ctags_install, desc_stats, rd_stats, tags_data]
- :heavy_check_mark: uses 'roxygen2'.
- :heavy_check_mark: 'DESCRIPTION' has a URL field.
- :heavy_check_mark: 'DESCRIPTION' has a BugReports field.
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/_snaps/extra-checks/checks-print.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ v Package is already on CRAN.
x Package depends on the following obsolete packages: [blah]
x does not have a 'codemeta.json' file.
x does not have a 'contributing' file.
x The following functions have no documented return values: [ctags_install, desc_stats, rd_stats, tags_data]
v uses 'roxygen2'.
v 'DESCRIPTION' has a URL field.
v 'DESCRIPTION' has a BugReports field.
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/_snaps/pkgcheck/checks.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ <h2>Checks for <a href>testpkgchecknotapkg (v0.0.0.9000)</a></h2>
<li>✅ Package name is available</li>
<li>❌ does not have a ‘codemeta.json’ file.</li>
<li>❌ does not have a ‘contributing’ file.</li>
<li>❌ The following function has no documented return value: [test_fn]</li>
<li>✅ uses ‘roxygen2’.</li>
<li>❌ ‘DESCRIPTION’ does not have a URL field.</li>
<li>❌ ‘DESCRIPTION’ does not have a BugReports field.</li>
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/_snaps/pkgcheck/checks.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ git hash: [](/tree/)
- :heavy_check_mark: Package name is available
- :heavy_multiplication_x: does not have a 'codemeta.json' file.
- :heavy_multiplication_x: does not have a 'contributing' file.
- :heavy_multiplication_x: The following function has no documented return value: [test_fn]
- :heavy_check_mark: uses 'roxygen2'.
- :heavy_multiplication_x: 'DESCRIPTION' does not have a URL field.
- :heavy_multiplication_x: 'DESCRIPTION' does not have a BugReports field.
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-list-checks.R
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ test_that ("list-checks", {
chks <- list_pkgchecks (),
"The following checks are currently implemented"
)
expect_length (chks, 18L)
expect_length (chks, 19L)

expect_silent (
chks2 <- list_pkgchecks (quiet = TRUE)
Expand Down

0 comments on commit 5e2002f

Please sign in to comment.