Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split app.rb into smaller files #88

Merged
merged 4 commits into from
Dec 23, 2023
Merged

Split app.rb into smaller files #88

merged 4 commits into from
Dec 23, 2023

Conversation

moozzi
Copy link
Member

@moozzi moozzi commented Dec 22, 2023

#82

@moozzi moozzi requested a review from postmodern December 22, 2023 15:05
@moozzi
Copy link
Member Author

moozzi commented Dec 22, 2023

Not sure about require's and if they are handled correctly.

@postmodern
Copy link
Member

@AI-Mozi is this ready to be merged? Everything looks like it should work. Given that the other files are relatively required after the main app.rb file it should work.

@moozzi
Copy link
Member Author

moozzi commented Dec 23, 2023

If you don't have any objections then it is ready to be merged.
All routes were working correctly for me.

@postmodern postmodern merged commit 4fdf9da into ronin-rb:main Dec 23, 2023
4 checks passed
@moozzi moozzi mentioned this pull request Dec 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postmodern postmodern postmodern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moozzi @postmodern