Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix body height #105

Merged
merged 2 commits into from
May 3, 2024
Merged

Fix body height #105

merged 2 commits into from
May 3, 2024

Conversation

moozzi
Copy link
Member

@moozzi moozzi commented Apr 23, 2024

This changes fix display for the bodies with no elements like queue.

Before
Screenshot 2024-04-23 at 21 02 40
After
Screenshot 2024-04-23 at 21 03 52

@moozzi moozzi force-pushed the body_css_height_fix branch from 592f6c9 to 763ff8d Compare April 23, 2024 19:08
@moozzi moozzi self-assigned this Apr 23, 2024
@postmodern
Copy link
Member

I think min-height should use 100vh or something more relative to the screen's height. On my display (2560x1440) I get this:
localhost_1337_queue

@postmodern postmodern self-requested a review April 24, 2024 01:22
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still displaying weird on my screen (2560x1440).

@moozzi
Copy link
Member Author

moozzi commented Apr 24, 2024

min-width: 75vh should looks ok, could you check it on your display?

@postmodern
Copy link
Member

@AI-Mozi 75vh and 70vh pushes the footer just below the bottom of the window, which I think is the goal?

@moozzi
Copy link
Member Author

moozzi commented Apr 24, 2024

My goal was to make body min-heigh big enough to remove the "white section" from my first image.

@postmodern
Copy link
Member

@AI-Mozi do we want the footer to be at the bottom of the page and visible, if there's no page content, or should it always be below the first page and require scrolling down to view it?

@moozzi
Copy link
Member Author

moozzi commented May 3, 2024

@postmodern Imo footer should be placed just below the first page, so it won't be visible until we scroll a bit, even on empty pages.

@postmodern postmodern merged commit 5ada7f7 into ronin-rb:main May 3, 2024
5 checks passed
@postmodern
Copy link
Member

Changed min-height to 70vh and squash merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants