move js to public, move _add_notes to _notes

app.rb

@@ -362,7 +362,7 @@ class App < Sinatra::Base
         if @record.notes.create!(body: params[:body])
           flash[:success] = "Note added successfully."
         else
-          flash[:danger] = "Something went wrong!"
+          flash[:danger] = "Failed to create Note."
         end
 
         redirect "/db/#{name}/#{params[:id]}"

public/javascript/notes.js

@@ -0,0 +1,28 @@
+const Notes = {
+  init() {
+    (document.querySelectorAll('.delete-note') || []).forEach(button => {
+      button.addEventListener('click', () => {
+        const noteId = button.getAttribute('data-note-id');
+        Notes.delete(noteId, button)
+      });
+    });
+  },
+
+  delete(noteId, button) {
+    fetch(`${document.location}/notes/${noteId}`, {
+      method: 'DELETE'
+    })
+    .then(response => {
+      if (response.ok) {
+        button.parentElement.parentElement.remove();
+      } else {
+        console.error('Failed to delete note');
+      }
+    })
+    .catch(error => {
+      console.error('Error:', error);
+    });
+  }
+};
+
+ready(Notes.init);

views/_notes.erb

@@ -1,4 +1,6 @@
-<% if notes.present? %>
+<script type="text/javascript" src="/javascript/notes.js"></script>
+
+<% unless notes.empty? %>
   <h3>Notes</h3>
     <% notes.each do |note| %>
       <div class="box">
@@ -15,29 +17,4 @@
     <% end %>
 <% end %>
 
-<script>
-  const deleteButtons = document.querySelectorAll('.delete-note');
-  const path = '<%= request.path_info %>'
-  deleteButtons.forEach(button => {
-    button.addEventListener('click', () => {
-      const noteId = button.getAttribute('data-note-id');
-      deleteNote(noteId, button)
-    });
-  });
-
-  function deleteNote(noteId, button) {
-    fetch(`${path}/notes/${noteId}`, {
-      method: 'DELETE'
-    })
-    .then(response => {
-      if (response.ok) {
-        button.parentElement.parentElement.remove();
-      } else {
-        console.error('Failed to delete note');
-      }
-    })
-    .catch(error => {
-      console.error('Error:', error);
-    });
-  }
-</script>
+<%= partial(:add_note) %>

views/db/advisories/show.erb

@@ -100,5 +100,3 @@
 </table>
 
 <%= partial(:notes, notes: @advisory.notes) %>
-
-<%= partial(:add_note, parent: @advisory) %>

views/db/credentials/show.erb

@@ -46,5 +46,3 @@
 </table>
 
 <%= partial(:notes, notes: @credential.notes) %>
-
-<%= partial(:add_note, parent: @credential) %>

views/db/email_addresses/show.erb

@@ -39,5 +39,3 @@
 
 
 <%= partial(:notes, notes: @email_address.notes) %>
-
-<%= partial(:add_note, parent: @email_address) %>

views/db/host_names/show.erb

@@ -47,5 +47,3 @@
 </table>
 
 <%= partial(:notes, notes: @host_name.notes) %>
-
-<%= partial(:add_note, parent: @host_name) %>

views/db/ip_addresses/show.erb

@@ -93,5 +93,3 @@
 </table>
 
 <%= partial(:notes, notes: @ip_address.notes) %>
-
-<%= partial(:add_note, parent: @ip_address) %>

views/db/mac_addresses/show.erb

@@ -57,4 +57,3 @@
 
 <%= partial(:notes, notes: @mac_address.notes) %>
 
-<%= partial(:add_note, parent: @mac_address) %>

views/db/open_ports/show.erb

@@ -82,5 +82,3 @@
 
 
 <%= partial(:notes, notes: @open_port.notes) %>
-
-<%= partial(:add_note, parent: @open_port) %>

views/db/passwords/show.erb

@@ -47,5 +47,3 @@
 
 
 <%= partial(:notes, notes: @password.notes) %>
-
-<%= partial(:add_note, parent: @password) %>

views/db/ports/show.erb

@@ -65,4 +65,3 @@
 
 <%= partial(:notes, notes: @port.notes) %>
 
-<%= partial(:add_note, parent: @port) %>

views/db/services/show.erb

@@ -60,4 +60,3 @@
 
 <%= partial(:notes, notes: @service.notes) %>
 
-<%= partial(:add_note, parent: @service) %>

views/db/urls/show.erb

@@ -98,5 +98,3 @@
 </table>
 
 <%= partial(:notes, notes: @url.notes) %>
-
-<%= partial(:add_note, parent: @url) %>

views/db/user_names/show.erb

@@ -43,5 +43,3 @@
 </table>
 
 <%= partial(:notes, notes: @user_name.notes) %>
-
-<%= partial(:add_note, parent: @user_name) %>