This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): suppress noUnusedVariables's false positive diagnostics when using indexed type #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
nissy-dev
changed the title
nissy-dev
commented
Jul 2, 2023
| @@ -25,6 +25,5 @@ | |||
| "function f() { var a; if (test) { var a; } }", | |||
| "for (var a, a;;);", | |||
| "for (;;){ var a, a,;}", | |||
| "function f(x) { var x = 5; }", | |||
| "interface A { [index: number]: string; [index: number]: string; }" | |||
There was a problem hiding this comment.
Semantic analyzer no longer handle identifiers of type variable, so I removed.
In this case, tsc throw the syntax error.
Thus, I seem that it is better to make this rule in syntax rule like noDuplicatePrivateClassMembers.
nissy-dev
commented
Jul 2, 2023
Comment on lines
+133
to
+137
| redeclarations.push(Redeclaration { | ||
| name, | ||
| declaration: *first_text_range, | ||
| redeclaration: id_binding.syntax().text_trimmed_range(), | ||
| }) |
There was a problem hiding this comment.
This rule no longer handles the case like interface A { [index: number]: string; [index: number]: string; }, so I removed unnecessary logic.
Conaclos
approved these changes
Jul 2, 2023
… TsIndexSignatureParameter
github-actions
bot
added
A-Formatter
nissy-dev
commented
Jul 4, 2023
| @@ -2066,9 +2066,11 @@ TsIndexSignatureTypeMember = | |||
| // { [a: string]: number } | |||
| // ^^^^^^^^^ | |||
| TsIndexSignatureParameter = | |||
| binding: JsIdentifierBinding | |||
| binding: TsIndexSignatureParameterName | |||
There was a problem hiding this comment.
I introduce the new CST node for the binding of TsIndexSignatureParameter. I think this binding is not JsIdentifierBinding.
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
🔥 Regression (28):ts/babel
ts/microsoft
|
|
This PR doesn't pass some tests, so I will rework and create the another PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4634
Test Plan
I update some snapshot tests.