Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Privacy Manifest to RollbarNotifier #344

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Added Privacy Manifest to RollbarNotifier #344

merged 5 commits into from
Apr 22, 2024

Conversation

matux
Copy link
Collaborator

@matux matux commented Apr 22, 2024 •
edited
Loading

Description of the change

This PR adds a Privacy Manifest file to the Common, Crash and Notifier targets in both the Package.swift and Pod specs.

Generated privacy report for RollbarDemo

After archiving an application that integrates with Rollbar, generating a privacy report now produces the following report:
RollbarDemo-PrivacyReport 2024-04-22 19-20-31.pdf

Settings

Screenshot 2024-04-22 at 7 06 24 PM

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Issue from task tracker has a link to this pull request

@matux matux self-assigned this Apr 22, 2024
@matux matux changed the title Added Privacy Manifest to Common, Crash and Notifier targets Added Privacy Manifest to RollbarNotifier Apr 22, 2024
@matux matux merged commit 18439fb into master Apr 22, 2024
1 check passed
@matux matux deleted the matux/privacy-manifest branch April 22, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alif alif alif approved these changes

Assignees

@matux matux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matux @alif