feat: use dbus for notifications #41
Conversation
You can add the person as co-author in the commit. Regarding the PR: The notify class should have the systray as a fallback, not remove it IMHO.
I will need to setup a dedicated laptop for powerkit development/testing, can do so this weekend. |
|
@rodlie did you get any time to take a closer look at this? |
|
ping @rodlie |
snprajwal
force-pushed
the
dbus-notif
branch
from
82d3455 to
71a2af6
Compare
|
I don't have time to test anything until next week. Too much stuff do to before Christmas :) |
|
Of course, no worries. Merry Christmas :D |
Co-authored by: Tassos Manganaris <[email protected]> Signed-off-by: Prajwal S N <[email protected]>
Signed-off-by: Prajwal S N <[email protected]>
|
@rodlie I've fixed CI for now, we should probably upgrade the project to use Qt6 soon, since Qt4 is fully deprecated, and Qt5 is on the way to deprecation |
|
Hi, Sorry for the late reply, finally had some time to work on powerkit. There were several issues that had to be resolved, mostly changes in org.freedesktop.PowerManagement etc since I used it last. I have a lot of pending commits, so I will delay testing notifications for a week or so. Don't worry, I will include your changes. |
|
Regarding Qt. I have already removed support for Qt4. Qt 5.6 is now the minimum required version. I will also fix remaning deprecated warnings for Qt 5.15. Feel free to test and fix Qt6 issues, but don't break Qt5. |
Fixes #36
I mostly fixed and made @Tass0sm's solution work, do let me know if it's possible for me to credit them for the contents of the commit.