Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk-21 chiselled runtime skeleton #464

Closed
wants to merge 20 commits into from

Conversation

vpa1977
Copy link
Collaborator

@vpa1977 vpa1977 commented Jan 14, 2025

Changes proposed in this pull request:

  • This MR introduces openjdk-21 chiselled runtime skeleton: basic rock and headless tests inherited from openjdk-17 chiselled jre.

Picture of a cool ROCK:

summary: OpenJDK 21 headless runtime environment
description: |
This rock provides OpenJDK 21 runtime environment including the following modules:
- java.base
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add module descriptions in a followup doc MR.

@vpa1977 vpa1977 marked this pull request as ready for review January 14, 2025 02:30
@vpa1977 vpa1977 requested a review from cjdcordeiro January 14, 2025 02:32
Copy link
Contributor

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving our offline discussion here:

there's one thing I'd ask you to check pls. This new channel channels/21/edge actually has the files for another version (17). That will cause the central CI to pick it up and release those images

(as you can see from #467 (which you can close btw))

So, could you please double check that the recently updated tags in https://hub.docker.com/r/ubuntu/jre/tags are actually comprising the correct jre version?

As for this PR, we also need to decide something:

are you going to keep using that repo? I think you should move it to the canonical org, for a few reasons: 1) the CI won't build rocks inside the rockcrafters org; 2) that org is kind of a community playground (we still have jre and .net images there just because they are still Docker Images and we have some central CI for them there);

I had to do this: c754abc

To keep the CI from failing, cause it's now mixing the 21 branch name with the 17 version as indicated in that branch's files

@cjdcordeiro
Copy link
Contributor

I've also renamed the branch with the wip prefix just to prevent the CI from spamming

@vpa1977 vpa1977 closed this Jan 14, 2025
@vpa1977 vpa1977 deleted the openjdk-21-draft branch January 15, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants