-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk-21 chiselled runtime skeleton #464
Conversation
Initial commit for openjdk-21 headless rock. todo: module descriptions
Update test docker files for maven builder and jdk builder
PDFBox test checks headless awt that is not present in openjdk 21 rock
Rename test images to simplify manual testing.
Make updates to the container tests due to: - /tmp present in the container - pebble is entrypoint as opposed to java - use current user instead of app
summary: OpenJDK 21 headless runtime environment | ||
description: | | ||
This rock provides OpenJDK 21 runtime environment including the following modules: | ||
- java.base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add module descriptions in a followup doc MR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving our offline discussion here:
there's one thing I'd ask you to check pls. This new channel channels/21/edge actually has the files for another version (17). That will cause the central CI to pick it up and release those images
(as you can see from #467 (which you can close btw))
So, could you please double check that the recently updated tags in https://hub.docker.com/r/ubuntu/jre/tags are actually comprising the correct jre version?
As for this PR, we also need to decide something:
are you going to keep using that repo? I think you should move it to the canonical org, for a few reasons: 1) the CI won't build rocks inside the rockcrafters org; 2) that org is kind of a community playground (we still have jre and .net images there just because they are still Docker Images and we have some central CI for them there);
I had to do this: c754abc
To keep the CI from failing, cause it's now mixing the 21 branch name with the 17 version as indicated in that branch's files
I've also renamed the branch with the |
Changes proposed in this pull request:
Picture of a cool ROCK: