Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup zig #7588

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Minor cleanup zig #7588

merged 3 commits into from
Feb 8, 2025
+15 −21

Conversation

bhansconnect
Copy link
Collaborator

  1. Switch fuzzer to ReleaseSafe
  2. Update not on fuzzer needing llvm
  3. Use c allocator as our gpa
  4. Use musl on linux.
  5. Just zig build test in CI.

@bhansconnect
Minor cleanup zig
a915d29 
1. Switch fuzzer to ReleaseSafe
2. Update not on fuzzer needing llvm
3. Use c allocator as our gpa
4. Use musl on linux.
5. Just `zig build test` in CI.
@bhansconnect
fix default target
4bf6b72
@bhansconnect
also update old ci workflow ci to not run on zig yml changes
ebd9871
@bhansconnect
Copy link
Collaborator Author

  1. Updates zig code and ci expecting only zig test to run.
  2. Realizes that updating zig ci runs old ci
  3. Doesn't want to wait on old ci
  4. Updates old ci to not run on updating zig ci
  5. Realizes that updating old ci to not run on zig ci leads to running old ci
  6. Waits on old ci

smores56
smores56 approved these changes Feb 8, 2025
View reviewed changes
Copy link
Collaborator

@smores56 smores56 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big LGTM from me

@smores56 smores56 enabled auto-merge February 8, 2025 02:27
@smores56 smores56 merged commit 4d5835f into main Feb 8, 2025
27 checks passed
@smores56 smores56 deleted the zig-misc branch February 8, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smores56 smores56 smores56 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhansconnect @smores56