Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade examples to snake_case builtins and PNC #228

Merged
merged 44 commits into from
Jan 31, 2025
Merged

Conversation

lukewilliamboswell
Copy link
Collaborator

Paired with the breaking change roc-lang/roc#7463

smores56
smores56 previously approved these changes Jan 10, 2025
@@ -15,22 +15,24 @@ Model : {}
# generate css by running `tailwindcss`,...
# In this case we don't have anything to initialize, so it is just `Task.ok {}`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this Task thing? I've never heard of it.

@Anton-4 Anton-4 self-assigned this Jan 10, 2025
@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 11, 2025

All done :)
I did both updates and improvements of the example code and README.

@Anton-4 Anton-4 removed their assignment Jan 11, 2025
@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 11, 2025

To update ImportPackageFromModule we will need to first upgrade roc-lang/unicode.

This still needs to be done

@Anton-4 Anton-4 self-assigned this Jan 24, 2025
@Anton-4 Anton-4 removed their assignment Jan 24, 2025
@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 24, 2025

Remaining:

@lukewilliamboswell lukewilliamboswell marked this pull request as ready for review January 25, 2025 00:20
smores56
smores56 previously approved these changes Jan 25, 2025
@Anton-4 Anton-4 changed the title Upgrade examples to snake_case builtins and PNC DO NOT MERGE Upgrade examples to snake_case builtins and PNC Jan 25, 2025
@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 25, 2025

I added "DO NOT MERGE" to the PR title so it does not get merged before TESTING is turned into nightly

@Anton-4 Anton-4 changed the title DO NOT MERGE Upgrade examples to snake_case builtins and PNC Upgrade examples to snake_case builtins and PNC Jan 31, 2025
@Anton-4 Anton-4 merged commit e00787f into main Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants