-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize CAN rework #243
Finalize CAN rework #243
Conversation
There is little advantage in using this CAN feature and may affect performance.
In case a string literal was passed, compilers kept choosing the template version instead.
4499b78
to
9fb6962
Compare
Follows up 9fb6962.
Sometimes, a malformed CAN frame spoils canWrite which then attempts to send it over and over again.
We have been instructed to request homing mode in order to stop controlling via external reference torque. This also works (and has been reported to support) in the profile velocity -> CSP case.
30a2927
to
49407e2
Compare
5805184
to
cf1aeaa
Compare
Caused by monitor threads still attempting to perform a SDO transfer after CAN bus threads have been stopped.
ca29776
to
4eb2165
Compare
This exploded on TEO's rightArm-lacquey configuration with a simple `getEncoders` call as Lacquey does not implement IEncoders. Since this mapper targets all available devices, it needs to have this restriction relaxed and hope callers will sort it out on their end (e.g. cbw2).
Now it is good to go. Optional side-quests have been added in the description. Keep in mind commit ef71fc0 concerning the internal template implementation check ( yarp-devices/libraries/YarpDeviceMapperLib/DeviceMapper.hpp Lines 175 to 190 in ef71fc0
yarp-devices/libraries/YarpDeviceMapperLib/DeviceMapper.hpp Lines 196 to 212 in ef71fc0
|
Follow-up of #229 and a final (?) take on the [CAN-TEO] project.
Closes #160, closes #170, closes #221, closes #222, closes #223, closes #231, closes #232, closes #242.
The following substasks have been considered but finally discarded or deferred until a later moment:
PRIVATE
in CMake's usage requirements).ICanBusSharer::registerSender
into its own interface (similarly toCanMessageNotifier
), use this in CanOpenNodeLib's classes.CanMessageNotifier
toICanMessageNotifier
?