-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement position direct mode #220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #198, check that issue for a full rationale.
This PR re-implements
yarp::dev::IPositionDirect
mode on the iPOS drives. Low-level CAN bus communications have been refactored in the following manner:IRemoteVariables
interface. Default is PT.setPosition()
send rate from clients to CAN master (YARP comms), and the other that manages the rate at which the PT/PVT buffer is filled up (CAN comms). It is expected that the former is at least equal or more frequent than the latter.LinearInterpolationBuffer
class andPtBuffer
+PvtBuffer
subclasses, and two new methods in theITechnosoftIpos
interface:sendLinearInterpolationTarget()
andsendLinearInterpolationStart()
.LinearInterpolationBuffer
class tree.yarp::dev::IRemoteVariables
has been preserved (it was meant to serve a different purpose in earlier iterations of this patchset) in spite of some serious pitfalls described at Make position direct mode usable #198 (comment) (and also Clean CAN raw subdevice interfaces #211 (comment) regarding joint ids), it's only intended for use via RPC for ease of access to low-level configuration (see first three bullets on this list).yarp-devices/libraries/YarpPlugins/CanBusControlboard/PositionDirectThread.cpp
Lines 28 to 30 in a70f446