Review linked libraries

roboticslab-uc3m · May 15, 2019 · 4fe827f · 4fe827f
1 parent 8f3a559
commit 4fe827f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/libraries/YarpTinyMathLib/CMakeLists.txt b/libraries/YarpTinyMathLib/CMakeLists.txt
@@ -12,8 +12,8 @@ if(ENABLE_YarpTinyMathLib)
 
     set_target_properties(YarpTinyMathLib PROPERTIES PUBLIC_HEADER YarpTinyMath.hpp)
 
-    target_link_libraries(YarpTinyMathLib YARP::YARP_sig
-                                          YARP::YARP_math)
+    target_link_libraries(YarpTinyMathLib PUBLIC YARP::YARP_sig
+                                          PRIVATE YARP::YARP_math)
 
     target_include_directories(YarpTinyMathLib PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
                                                       $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)

diff --git a/libraries/YarpTinyMathLib/YarpTinyMath.cpp b/libraries/YarpTinyMathLib/YarpTinyMath.cpp
@@ -2,6 +2,8 @@
 
 #include "YarpTinyMath.hpp"
 
+#include <yarp/math/Math.h>  // provides: eye, operators
+
 // ----------------------------------------------------------------------------
 
 double roboticslab::toDeg(const double inRad)

diff --git a/libraries/YarpTinyMathLib/YarpTinyMath.hpp b/libraries/YarpTinyMathLib/YarpTinyMath.hpp
@@ -9,8 +9,6 @@
 #include <yarp/sig/Vector.h>
 #include <yarp/sig/Matrix.h>
 
-#include <yarp/math/Math.h>  // provides: eye, operators
-
 namespace roboticslab
 {