Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not free const char* #30

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Do not free const char* #30

merged 1 commit into from
Oct 8, 2024

Conversation

robbr48
Copy link
Owner

@robbr48 robbr48 commented Oct 8, 2024

free() should not be called for const char* variables allocated in strdup()

Also use enums instead of hard-coded strings for default values.

@robbr48 robbr48 added the bug Something isn't working label Oct 8, 2024
@robbr48 robbr48 self-assigned this Oct 8, 2024
@robbr48 robbr48 merged commit 7e7fb20 into main Oct 8, 2024
6 checks passed
@robbr48 robbr48 deleted the dont_free_const_char branch October 8, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant