Improves comment.

rmrk-team · Dec 4, 2023 · 28977d0 · 28977d0
1 parent 2f617db
commit 28977d0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/contracts/RMRK/equippable/RMRKMinifiedEquippable.sol b/contracts/RMRK/equippable/RMRKMinifiedEquippable.sol
@@ -390,9 +390,7 @@ contract RMRKMinifiedEquippable is
         uint256 destinationId,
         bytes memory data
     ) internal virtual {
-        // It seems redundant, but otherwise it would revert with no error
         _checkDestination(to);
-
         _innerMint(to, tokenId, destinationId, data);
         _sendToNFT(address(0), to, 0, destinationId, tokenId, data);
     }
@@ -2066,7 +2064,7 @@ contract RMRKMinifiedEquippable is
      * @param to Address of the destination
      */
     function _checkDestination(address to) internal view {
-        // It seems redundant, but otherwise it would revert with no error
+        // Checking if it is a contract before calling it seems redundant, but otherwise it would revert with no error
         if (to.code.length == 0) revert RMRKIsNotContract();
         if (!IERC165(to).supportsInterface(type(IERC7401).interfaceId))
             revert RMRKNestableTransferToNonRMRKNestableImplementer();

diff --git a/contracts/RMRK/nestable/RMRKNestable.sol b/contracts/RMRK/nestable/RMRKNestable.sol
@@ -444,9 +444,7 @@ contract RMRKNestable is Context, IERC165, IERC721, IERC7401, RMRKCore {
         uint256 destinationId,
         bytes memory data
     ) internal virtual {
-        // It seems redundant, but otherwise it would revert with no error
         _checkDestination(to);
-
         _innerMint(to, tokenId, destinationId, data);
         _sendToNFT(address(0), to, 0, destinationId, tokenId, data);
     }
@@ -1175,7 +1173,7 @@ contract RMRKNestable is Context, IERC165, IERC721, IERC7401, RMRKCore {
      * @param to Address of the destination
      */
     function _checkDestination(address to) internal view {
-        // It seems redundant, but otherwise it would revert with no error
+        // Checking if it is a contract before calling it seems redundant, but otherwise it would revert with no error
         if (to.code.length == 0) revert RMRKIsNotContract();
         if (!IERC165(to).supportsInterface(type(IERC7401).interfaceId))
             revert RMRKNestableTransferToNonRMRKNestableImplementer();