Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hub): fix actors overflowing with long state #1979

Conversation

NathanFlurry
Copy link
Member

Fixes FRONT-621

Copy link

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8540950
Status:⚡️  Build in progress...

View logs

Copy link

linear bot commented Jan 30, 2025

Copy link
Contributor

graphite-app bot commented Jan 30, 2025

Merge activity

  • Jan 30, 4:12 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 30, 4:13 AM EST: CI is running for this PR on a draft PR: #1980
  • Jan 30, 4:13 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1980.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

NathanFlurry added a commit that referenced this pull request Jan 30, 2025
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Modified the actors route component to address overflow issues with long state names in the Rivet Hub interface.

  • Added w-screen class in frontend/apps/hub/src/routes/_authenticated/_layout/projects/$projectNameId/environments/$environmentNameId/actors.tsx which may cause unintended horizontal scrolling issues since it forces 100vw width regardless of parent container
  • Consider using alternative width classes like w-full or max-w-full to prevent potential layout breakage while still fixing the overflow

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -43,7 +43,7 @@ function ProjectActorsRoute() {
}

return (
<div className="flex flex-col h-[calc(100vh-6.5rem)] bg-card -mx-4 -my-4">
<div className="flex flex-col w-screen h-[calc(100vh-6.5rem)] bg-card -mx-4 -my-4">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Using w-screen could cause horizontal scrolling issues if the parent container is narrower than the viewport. Consider using w-full instead to respect container boundaries.

@graphite-app graphite-app bot closed this Jan 30, 2025
@graphite-app graphite-app bot deleted the 01-30-fix_hub_fix_actors_overflowing_with_long_state branch January 30, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant