-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hub): fix actors overflowing with long state #1979
fix(hub): fix actors overflowing with long state #1979
Conversation
Merge activity
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Modified the actors route component to address overflow issues with long state names in the Rivet Hub interface.
- Added
w-screen
class infrontend/apps/hub/src/routes/_authenticated/_layout/projects/$projectNameId/environments/$environmentNameId/actors.tsx
which may cause unintended horizontal scrolling issues since it forces 100vw width regardless of parent container - Consider using alternative width classes like
w-full
ormax-w-full
to prevent potential layout breakage while still fixing the overflow
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -43,7 +43,7 @@ function ProjectActorsRoute() { | |||
} | |||
|
|||
return ( | |||
<div className="flex flex-col h-[calc(100vh-6.5rem)] bg-card -mx-4 -my-4"> | |||
<div className="flex flex-col w-screen h-[calc(100vh-6.5rem)] bg-card -mx-4 -my-4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Using w-screen could cause horizontal scrolling issues if the parent container is narrower than the viewport. Consider using w-full instead to respect container boundaries.
Fixes FRONT-621