feat(hub): actors and builds filters #1884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
3aec515
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://02370d39.rivet.pages.dev |
| Branch Preview URL: | https://01-18-feat-hub-actors-and-bu.rivet.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
3aec515
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e711f5cd.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://01-18-feat-hub-actors-and-bu.rivet-hub-7jb.pages.dev |
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Test" took an action on this PR • (01/18/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
jog1t
force-pushed
the
01-18-feat_hub_actors_and_builds_filters
branch
from
f262e16 to
2c837f4
Compare
jog1t
force-pushed
the
01-18-feat_hub_actors_and_builds_filters
branch
from
2c837f4 to
3aec515
Compare
|
I have a lot of smaller things I'd like to change later but we should ship something at bare minimum. For MVP, can we make it so it's not a sidebar but pops up below where the button is? You have to shift your entire focus to the other side of the screen. |
|
adding @MasterPtato since he is the tag meister |
MasterPtato
reviewed
Jan 21, 2025
This was referenced Jan 22, 2025
Closed
Merged
Merge activity
|
jog1t
added a commit
that referenced
this pull request
Jan 22, 2025
Closes FRONT-474
## Changes
- Added filtering capabilities to the actors list, allowing users to filter by tags and show/hide destroyed actors
- Enhanced the `TagsSelect` component to support better search functionality and display of selected options
- Added a new `ActorsFiltersSheet` component for managing actor filters
- Updated the builds page to support tag filtering
- Improved the Combobox component to handle multiple selections and show selected option counts
- Added visual indicators when filters are active
<div class='graphite__hidden'>
<div>🎥 Video uploaded on Graphite:</div>
<a href="https://app.graphite.dev/media/video/dOgs2Fo4NFCWV1dxDXM1/585cb609-058e-4c8a-ac73-54877b528129.mov">
<img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/dOgs2Fo4NFCWV1dxDXM1/585cb609-058e-4c8a-ac73-54877b528129.mov">
</a>
</div>
<video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/dOgs2Fo4NFCWV1dxDXM1/585cb609-058e-4c8a-ac73-54877b528129.mov">Untitled.mov</video>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FRONT-474
Changes
TagsSelectcomponent to support better search functionality and display of selected optionsActorsFiltersSheetcomponent for managing actor filters