feat: add error screen for network issues #1871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
e90cccd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d735cea1.rivet.pages.dev |
| Branch Preview URL: | https://01-17-feat-add-error-screen.rivet.pages.dev |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Deploying rivet-hub with
|
| Latest commit: |
93407bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://63eeb6e1.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://01-17-feat-add-error-screen.rivet-hub-7jb.pages.dev |
jog1t
force-pushed
the
01-17-feat_add_error_screen_for_network_issues
branch
from
626d711 to
c74ec1e
Compare
jog1t
force-pushed
the
01-17-feat_use_new_onboarding_flow_when_linking_a_device
branch
from
07e50ec to
bdddd12
Compare
jog1t
force-pushed
the
01-17-feat_add_error_screen_for_network_issues
branch
from
c74ec1e to
d72b95e
Compare
jog1t
changed the base branch from
01-17-feat_use_new_onboarding_flow_when_linking_a_device
to
graphite-base/1871
jog1t
force-pushed
the
01-17-feat_add_error_screen_for_network_issues
branch
from
d72b95e to
9da70a7
Compare
jog1t
force-pushed
the
graphite-base/1871
branch
from
bdddd12 to
1a80f92
Compare
Graphite Automations"Test" took an action on this PR • (01/18/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
jog1t
force-pushed
the
01-17-feat_add_error_screen_for_network_issues
branch
from
9da70a7 to
93407bf
Compare
NathanFlurry
approved these changes
Jan 20, 2025
Merge activity
|
jog1t
added a commit
that referenced
this pull request
Jan 20, 2025
Closes FRONT-470 ## Changes Improves error handling in the Hub frontend by: - Adding a `CatchBoundary` component to handle routing errors - Creating a new `LayoutedErrorComponent` to ensure errors are displayed within the page layout - Adding network issue error handling for API failures - Ensuring error states maintain consistent styling and layout The error handling now properly catches and displays: - Network connectivity issues - Not found errors - Authentication errors - General application errors All errors will now be displayed within the standard page layout instead of breaking the UI structure.
graphite-app
bot
deleted the
01-17-feat_add_error_screen_for_network_issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FRONT-470
Changes
Improves error handling in the Hub frontend by:
CatchBoundarycomponent to handle routing errorsLayoutedErrorComponentto ensure errors are displayed within the page layoutThe error handling now properly catches and displays:
All errors will now be displayed within the standard page layout instead of breaking the UI structure.