chore(examples): add react/next.js example #1744
Conversation
Deploying rivet with
|
| Latest commit: |
41fa425
|
| Status: | ⚡️ Build in progress... |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
jog1t
force-pushed
the
12-30-chore_examples_add_react_next.js_example
branch
from
c8b7445 to
86f2b2b
Compare
jog1t
force-pushed
the
12-30-fix_actors-sdk_use_proper_binary_fromat_when_receiving_cbor_data
branch
from
d20807e to
607a134
Compare
jog1t
force-pushed
the
12-30-chore_examples_add_react_next.js_example
branch
from
86f2b2b to
8c43a98
Compare
jog1t
force-pushed
the
12-30-fix_actors-sdk_use_proper_binary_fromat_when_receiving_cbor_data
branch
from
607a134 to
8ce1794
Compare
jog1t
force-pushed
the
12-30-chore_examples_add_react_next.js_example
branch
from
8c43a98 to
7eb16d9
Compare
jog1t
force-pushed
the
12-30-fix_actors-sdk_use_proper_binary_fromat_when_receiving_cbor_data
branch
from
8ce1794 to
015295a
Compare
jog1t
force-pushed
the
12-30-chore_examples_add_react_next.js_example
branch
from
7eb16d9 to
512fbb4
Compare
Deploying rivet-hub with
|
| Latest commit: |
512fbb4
|
| Status: | 🚫 Build failed. |
jog1t
force-pushed
the
12-30-fix_actors-sdk_use_proper_binary_fromat_when_receiving_cbor_data
branch
from
015295a to
618a98a
Compare
jog1t
force-pushed
the
12-30-chore_examples_add_react_next.js_example
branch
from
512fbb4 to
012d6ef
Compare
There was a problem hiding this comment.
i'm reviewing the code at the top of the stack, but leaving the review on this pr.
should we fold 1756 in to 1744 bc this is incomplete?
i think we should rename "examples/react" to something more specific like "react-rsc" or "react-sdui" or "react-server-driven-ui." we're going to have a lot of examples, so we need to keep them organized. my branch has a "registry" of examples so we'll be able to auto-gen uis for these.
is there a problem with including the deno.json and rivet.json in the root of the react project then storing actors under src/actors?
reading the react code looks more complicated at the surface than it actually is. ideally it's as simple to read as the thing we put on twitter. throwing out some ideas, but use your best judgement:
- throw chat components under components folder. so src/actors & src/components & src/app
- name the files clearer: "server-driven-ui" is not well differentiated from "simple-chat." took me a while to realize these are two separate examples.
- why not merge together
SimpleChatandChatContent? is this just a convention to split it out i'm missing?
clarifying: we don't have the ability to automatically call getMessages like the idea we proposed right?
jog1t
force-pushed
the
12-30-fix_actors-sdk_use_proper_binary_fromat_when_receiving_cbor_data
branch
from
618a98a to
748f4af
Compare
jog1t
force-pushed
the
12-30-chore_examples_add_react_next.js_example
branch
from
012d6ef to
41fa425
Compare
jog1t
merged commit 41fa425
into
12-30-fix_actors-sdk_use_proper_binary_fromat_when_receiving_cbor_data
A more complex, server driver ui, example will be added soon.
Changes