Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hide actor resources #441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: hide actor resources #441

wants to merge 1 commit into from
+0 −4

Conversation

jog1t
Copy link
Contributor

@jog1t jog1t commented Dec 16, 2024 •
edited
Loading

Closes WEB-236

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 16, 2024 •
edited
Loading

Deploying hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: f86b4c4
Status: ✅  Deploy successful!
Preview URL: https://80812f3f.hub-3av.pages.dev
Branch Preview URL: https://12-16-feat-hide-actor-resour.hub-3av.pages.dev

View logs

@jog1t Graphite App
Copy link
Contributor Author

jog1t commented Dec 16, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t mentioned this pull request Dec 16, 2024
Closed
@jog1t jog1t self-assigned this Dec 16, 2024
@linear Linear
Copy link

linear bot commented Dec 16, 2024

WEB-236 Hide CPU resource limit for actors in resources tab

@jog1t jog1t requested a review from a team December 16, 2024 10:38
@jog1t jog1t marked this pull request as ready for review December 16, 2024 10:38
@jog1t jog1t changed the base branch from 12-14-feat_new_onboarding to graphite-base/441 December 17, 2024 00:18
@jog1t jog1t force-pushed the graphite-base/441 branch from 4ee877a to 6e04284 Compare December 17, 2024 00:18
@jog1t jog1t force-pushed the 12-16-feat_hide_actor_resources branch from 3674dc3 to 5dc102b Compare December 17, 2024 00:18
@jog1t jog1t changed the base branch from graphite-base/441 to main December 17, 2024 00:19
@jog1t jog1t force-pushed the 12-16-feat_hide_actor_resources branch from 5dc102b to f2a39ed Compare December 17, 2024 00:19
MasterPtato
MasterPtato reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@MasterPtato MasterPtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change only for isolates? You can still choose resources for container actors

@jog1t jog1t force-pushed the 12-16-feat_hide_actor_resources branch from f2a39ed to f86b4c4 Compare December 29, 2024 21:33
@jog1t
Copy link
Contributor Author

jog1t commented Dec 29, 2024

@MasterPtato how can I differentiate those two? 🤔

@MasterPtato Graphite App
Copy link
Contributor

it doesnt look like we expose it anywhere in the api, so ill have to fix that. its whether or not the build kind is js

https://github.com/rivet-gg/rivet/blob/main/sdks/api/fern/definition/actor/builds.yml#L120-L121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterPtato MasterPtato MasterPtato left review comments

Assignees

@jog1t jog1t

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jog1t @MasterPtato