feat(HUB-150): add a slight animation when opening app for a first time #14
Conversation
…-137 # Conflicts: # src/elements/pages/rvt-user-dashboard.ts
…b-150 # Conflicts: # src/elements/root/ui-root.ts # src/elements/root/ui-router.scss
Deploying with
|
| Latest commit: |
b13df33
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://284c34b1.hub-3av.pages.dev |
| Branch Preview URL: | https://feature-hub-150.hub-3av.pages.dev |
|
I like this, it's a nice touch. How do you feel about a bit more of a juicy curve, something like: https://cubic-bezier.com/#.27,1.37,.87,1 (this is a rough curve, could be improved) I think I'm going to make this my new GitHub signature, y'all are going to get sick and tired of it: https://www.youtube.com/watch?v=Fy0aCDmgnxg |
Screen.Recording.2023-10-31.at.10.43.55.PM.movNot sure if I'm catching you mid-changes, but seeing some weird issues here. Feel free to request another review whenever. |
|
@NicholasKissel it's not finished yet, will notify when it's ready! :) |
…-150 # Conflicts: # src/elements/root/ui-root.ts # src/routes.ts
|
Finally managed to bring back the animations, for now they're very subtle, but it's a nice start for something more advanced. @NathanFlurry let me what you think! |
|
Tbh, I'm not a big fan of the transition between pages. Since we aggressively cache things both on the client & server, most things load almost instantly (staging2 is super laggy for some reason though). And for the things that don't load instantly, I tend to prefer the placeholder loading with the shiny animation. There's also still a weird "flash" when switching between pages (from us loading data from the cache) that's a bit jarring when combined with the animation. Lmk if you want a video of this. @NicholasKissel @yusufsallam64 @MasterPtato open to your thoughts too |
|
I prefer a placeholder too. Given that transitions are a static duration, it means a page that isn't fully loaded by the time the transition is complete will still need placeholders anyway. |
|
Removed all animations. So the only thing that has left in this PR is the rename of components. |
No description provided.