Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contracts #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

miguel-nascimento
Copy link
Contributor

@miguel-nascimento miguel-nascimento commented Dec 11, 2024

we probably want to wait the new flow to be ready to merge all together

  • but I decided to open this PR so theo can have a reference about how to set up the rewards distribution contract

I'm unsure about the claim flow, since I couldn't test it (I dont have river balance to claim)

  • anyway, we will polish it in the next days

Tested delegate & authorize claimer with address zero.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
river-build-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:26am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:26am

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally, this file should be git ignored -- I can't remember if we had an special reason for not ignoring it

Comment on lines +1347 to +1349
const mainnetRiverTokenAddress = '0x53319181e003E7f86fB79f794649a2aB680Db244' satisfies Address
const baseRiverTokenAddress = '0x91930fd11ABAa5241241d3B07c02A8d0B5ac1920' satisfies Address
const baseGammaSepoliaTokenAddress = '0x24e3123E1b30E041E2df26Da9d6140c5B07Fe4F0' satisfies Address
Copy link
Contributor Author

@miguel-nascimento miguel-nascimento Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the next @river-build/generated version, we can replace this with values from npm

Comment on lines -2013 to 1381
address: {
[mainnet.id]: '0x53319181e003e7f86fb79f794649a2ab680db244',
[sepolia.id]: '0x40ef1bb984503bb5adef041a88a4f9180e8586f9',
},
},
{
name: 'RiverAuthorizer',
name: 'Authorizer',
address: {
[mainnet.id]: '0x0bEe55b52d01C4D5d4D0cfcE1d6e0baE6722db05',
[sepolia.id]: '0x2f5E8F6Fb7EcF63d13C13B698d1e0B3EA4Ef604B',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure if that's the most up-to-date address of the authorizer contract - if it is, we should document it in the river docs - only found one reference matching this mainnet address in the river repo (hardcoded in a solidity file - not even inside /contracts or /packages/generated)

},
}
abi: rewardDistributionAbi,
},
],
plugins: [
etherscan({
Copy link
Contributor Author

@miguel-nascimento miguel-nascimento Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would love to import abi from npm instead of using etherscan plugin or manually hardcoding abi in this app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant