-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MLS Queue service #2031
Add MLS Queue service #2031
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
I would consider changing this pattern here: river/packages/sdk/src/mls/group/groupService.ts Lines 198 to 201 in ba2d0a4
where the caller gets an external join message, but it also writes the group state to cache making it impossible to create a new external join message. we should be able to track the pending state in a better way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall i think it maps pretty well with the direction we've talked about. but i'm sure we'll find some things we want to change down the road anyway.
some things we'll need to take into account:
- sync resets (clean queue, decide what to do next)
- (?) make sure we don't advance groups too far (3 epochs?) until we're dead certain that the epoch list is closed in the node
Adds MLS Coordinator and Queue
In order to send messages client calls
encryptGroupEventEpochSecret
which matches that API ofencryptGroupEvent
.In order to receive messages, the Coordinator has to be hooked via an adapter. The adapter will come in a separate PR.