Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification service: new APN notification payload #1994

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

bas-vk
Copy link
Contributor

@bas-vk bas-vk commented Jan 9, 2025

Change APN payload format to reduce its size.

Strip the stream event before the notification is send if the size is guaranteed too large. If APN still reports that the payload is too large retry it with the stream event stripped from it.

Merge when there is clarity if we need to be backwards compatiblity.

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
river-sample-app ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 0:16am

@bas-vk bas-vk force-pushed the basvk/apn_notifications branch from b06c290 to 4ef8d72 Compare January 9, 2025 11:00
@bas-vk bas-vk force-pushed the basvk/apn_notifications branch 2 times, most recently from 7fac9a0 to 373c77a Compare January 9, 2025 13:32
@bas-vk bas-vk requested a review from erikolsson January 9, 2025 13:33
Copy link
Contributor

@erikolsson erikolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

core/node/notifications/event_processor.go Show resolved Hide resolved
@bas-vk bas-vk force-pushed the basvk/apn_notifications branch from 373c77a to 91a2137 Compare January 9, 2025 13:36
@bas-vk bas-vk force-pushed the basvk/apn_notifications branch from 91a2137 to e3f8b1a Compare January 9, 2025 14:07
@bas-vk bas-vk marked this pull request as ready for review January 9, 2025 14:46
@bas-vk bas-vk requested a review from sergekh2 as a code owner January 9, 2025 14:46
@bas-vk bas-vk requested a review from texuf as a code owner January 13, 2025 10:01
@bas-vk bas-vk merged commit 5173c57 into main Jan 14, 2025
9 checks passed
@bas-vk bas-vk deleted the basvk/apn_notifications branch January 14, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants