Fix data types around batch.{c,h} #1202
Merged
+124
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMatCodasip
force-pushed
the
fix-datatypes-around-batch
branch
2 times, most recently
from
a93b7cb to
3a139b8
Compare
en-sc
previously approved these changes
Jan 15, 2025
JanMatCodasip
force-pushed
the
fix-datatypes-around-batch
branch
from
3a139b8 to
7d22ec1
Compare
JanMatCodasip
commented
Jan 20, 2025
en-sc
previously approved these changes
Jan 20, 2025
Check that the value of dtmcs.abits is in the expected range.
Make corrections of data types in batch.{c,h} and in related code.
Some of the issues were found by activating "-Wconversion" in GCC,
others by inspecting the code manually.
This is an initial step towards being able to use "-Wconversion" on
RISC-V target code, which will give us bit more confidence when
refactoring or merging new patches.
Changes made:
- Check `dtmcs.abits` during examination.
- DMI address is no larger than 32-bits per the debug spec.
Changed address parameters of multiple functions from uint64_t
to uint32_t.
- The value passed to jtag_add_runtest() is now `unsigned int`,
not `int`. No need for `assert(idle <= INT_MAX)` anymore.
- `get_delay()` in batch.c can return an unsigned value.
- Added few assertions around `field->num_bits` in batch.c.
Change-Id: Ibfccd62d552063df6ab9b5a2d4ea4ed23617d3db
Signed-off-by: Jan Matyas <[email protected]>
JanMatCodasip
force-pushed
the
fix-datatypes-around-batch
branch
from
7d22ec1 to
a450a7d
Compare
en-sc
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the value of dtmcs.abits is in the expected range
during the target examination.
Make corrections of data types in batch.{c,h} and in related code.
Some of the issues were found by activating "-Wconversion" in GCC,
others by inspecting the code manually.
This is an initial step towards being able to use "-Wconversion" on
RISC-V target code, which will give us bit more confidence around
data types when refactoring or merging new patches.