Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIR-332: Add bytecode interpreter for validity polynomial calculation for keccak #168

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

shkoo
Copy link
Contributor

@shkoo shkoo commented Jan 21, 2025

No description provided.

@github-actions github-actions bot changed the title Add bytecode interpreter for validity polynomial calculation for keccak ZIR-332: Add bytecode interpreter for validity polynomial calculation for keccak Jan 21, 2025
@shkoo shkoo marked this pull request as ready for review January 21, 2025 20:03
@shkoo shkoo marked this pull request as draft January 27, 2025 17:59
shkoo added 8 commits January 29, 2025 12:59
I'm guessing it's because of cloning everything rather than just cloning some things.
…s better:

With new encodeblockop + new scheduler + clone everything: somewhere around 500 keccak/sec

With new encodeblockop + new scheduler + register-aware cloner:

1 runs of PO2=19 completed in 2.891s, avg=2.891s, 181357.063 cycles/sec, 906.633 keccak/sec

with new encodeblock + old scheduer + register-aware-cloner:

1 runs of PO2=19 completed in 2.154s, avg=2.154s, 243392.444 cycles/sec, 1216.758 keccak/sec
1 runs of PO2=19 completed in 2.139s, avg=2.139s, 245058.835 cycles/sec, 1225.089 keccak/sec
1211 with  regcount=40, 1355 with regcount=64,

with multiply-if:

regcount=64:

5 runs of PO2=19 completed in 9.734s, avg=1.947s, 269307.033 cycles/sec, 1346.309 keccak/sec

regcount=40:

5 runs of PO2=19 completed in 10.002s, avg=2.000s, 262104.110 cycles/sec, 1310.301 keccak/sec
…ec, 1457.162 keccak/sec

  __device__ static constexpr size_t getFpBufferSize() { return 1554; }
@shkoo shkoo force-pushed the nils/bytecode-interp branch from 6d6bfeb to 2505128 Compare February 4, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant