Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connections reconnect after inactivity #209

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pdp2121
Copy link
Collaborator

@pdp2121 pdp2121 commented Feb 22, 2024

High Level Overview of Change

On the VHS, even when a WebSocket connection is open, it stops receiving subscription messages for some periods and resumes. The issue has been raised here to the Core Ledger:
XRPLF/rippled#3180
It happened more often for some nodes than others. One approach to fix it in the immediate term is to reconnect after the ws remains open but no message has arrived in 1 minute.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

@pdp2121 pdp2121 marked this pull request as draft February 26, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant