Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update glog to 0.7.1 #961

Merged
merged 1 commit into from
Dec 15, 2024
Merged

chore(deps): update glog to 0.7.1 #961

merged 1 commit into from
Dec 15, 2024

Conversation

WhiredPlanck
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes # N/A

Feature

Describe feature of pull request

Update bundled glog to 0.7.1, a patch version that addresses several issues since 0.7.0 (some issues affect the build on Android). See https://github.com/google/glog/releases/tag/v0.7.1 .

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@ksqsf ksqsf merged commit ec40354 into rime:master Dec 15, 2024
10 checks passed
@WhiredPlanck WhiredPlanck deleted the deps-glog-0.7.1 branch December 15, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksqsf ksqsf ksqsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhiredPlanck @ksqsf