Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(windows): add x64 build #839

Closed
wants to merge 7 commits into from
Closed

ci(windows): add x64 build #839

wants to merge 7 commits into from

Conversation

lotem
Copy link
Member

@lotem lotem commented Mar 6, 2024 •
edited
Loading

No description provided.

@lotem lotem requested a review from fxliang March 6, 2024 11:39
@lotem lotem force-pushed the build_x64 branch 2 times, most recently from fdf1b66 to f6f5464 Compare March 6, 2024 13:04
@lotem lotem changed the title build(build.bat): add x64 option build(build.bat): add build_dir option Mar 6, 2024
@lotem lotem changed the title build(build.bat): add build_dir option build(build.bat): add build_dir variable Mar 6, 2024
fxliang
fxliang approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@fxliang fxliang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the description

deps_install_prefix rime_install_prefix must be full path, when build_dir must be dir_name only.

@lotem lotem force-pushed the build_x64 branch 3 times, most recently from 3c32532 to 5911bf1 Compare March 8, 2024 04:10
@lotem lotem changed the title build(build.bat): add build_dir variable ci(windows) add x64 build Mar 8, 2024
@lotem lotem changed the title ci(windows) add x64 build ci(windows): add x64 build Mar 8, 2024
@lotem lotem force-pushed the build_x64 branch 2 times, most recently from e18c419 to 162f1bc Compare March 8, 2024 07:28
@lotem lotem closed this Mar 8, 2024
@lotem lotem deleted the build_x64 branch March 8, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxyzh wxyzh wxyzh left review comments

@fxliang fxliang fxliang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lotem @fxliang @wxyzh